Difference between revisions of "Getting Your Pull Accepted"
imported>Cheridan (standards don't start after your PR is opened) |
imported>Cheridan (not all bugfix only prs are given amnesty) |
||
| Line 30: | Line 30: | ||
Pull requests must add, remove, or change only ONE feature or related group of features. Do not "bundle" together a bunch of things, as each change may be controversial and hold up everything else. In addition, it's simply neater. | Pull requests must add, remove, or change only ONE feature or related group of features. Do not "bundle" together a bunch of things, as each change may be controversial and hold up everything else. In addition, it's simply neater. | ||
| − | Bugfix-only PRs are | + | Bugfix-only PRs are granted some leniency, however not all bugfixes are made equal. It's possible to have a change that technically fixes a bug, but does so in a way that's hacky or otherwise undesirable. |
=== 5. Clearly State What Your Pull Request Does, All Of It === | === 5. Clearly State What Your Pull Request Does, All Of It === | ||
Revision as of 13:59, 3 October 2014
Work in progress...
So you've made a change to the code/sprites and want to make a Pull Request so we can add it to the game.
Before you do this, though, we have some requirements so your code doesn't make SS13's infamous spaghetti code problems even worse. Make sure your code fits these requirements or your pull will not be accepted. You may also want to read through the suggestions section.
Pull Request Requirements
1. Your code MUST compile.
This is a given. While we will not close your pull request over this, we will not accept it until it does compile cleanly. The Travis bot will check for this automatically, but you should check before you even commit. Warnings should also be cleared.
2. You MUST follow the coding standards
Please read through these Coding_Standards. The standards will change over time. Hopefully you already read through and made sure your code adhered to them before opening your pull request!
3. Do not automatically add FILE_DIR.
A recurring problem that we encounter is people adding commits that needlessly spam changes to the DME due to having "Automatically add FILE_DIR" set in their project settings. You'll know if you have this problem if you see this in your commit (as seen through github):
PRs that add things to FILE_DIR will be rejected.
To fix this problem:
- Open up DreamMaker
- Build > Preferences for tgstation.dme...
- Uncheck "Automatically set FILE_DIR for sub-directories"
- Check compile.
- Close DreamMaker and commit again.
4. Pull Requests Must Be Atomic
Pull requests must add, remove, or change only ONE feature or related group of features. Do not "bundle" together a bunch of things, as each change may be controversial and hold up everything else. In addition, it's simply neater.
Bugfix-only PRs are granted some leniency, however not all bugfixes are made equal. It's possible to have a change that technically fixes a bug, but does so in a way that's hacky or otherwise undesirable.
5. Clearly State What Your Pull Request Does, All Of It
Please do NOT withhold information about your pull request from us. This will get your pull request delayed and if it happens too often your pull request will be closed.
Suppose you fixed bug #1234 and changed the name and description of an item as a gag.
Bad:
In this PR I fixed bug #1234.
Acceptable:
In this PR I fixed bug #1234 and also modified the baton's name and description.
